Re: [PATCH 4/4] locking: Introduce smp_cond_acquire()

David Howells
2015-11-02T20:36:58Z

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > + smp_read_barrier_depends(); /* ctrl */ \
> > + smp_rmb(); /* ctrl + rmb := acquire */ \

Doesn't smp_rmb() imply an smp_read_barrier_depends() anyway? In
memory-barriers.txt, it says:

Read memory barriers imply data dependency barriers, and so can
substitute for them.

David