The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	Brendan Gregg <brendan.d.gregg@gmail.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH v3 1/4] perf report: Support folded callchain mode on --stdio
Date: Tue, 3 Nov 2015 09:21:52 +0100	[thread overview]
Message-ID: <20151103082152.GG23878@krava.brq.redhat.com> (raw)
In-Reply-To: <1446535111-31713-2-git-send-email-namhyung@kernel.org>

On Tue, Nov 03, 2015 at 04:18:28PM +0900, Namhyung Kim wrote:
> Add new call chain option (-g) 'folded' to print callchains in a line.
> The callchains are separated by semicolons, and preceded by (absolute)
> percent values and a space.
> 
> For example, following 20 lines can be printed in 3 lines with the
> folded output mode;
> 
>   $ perf report -g flat --no-children | grep -v ^# | head -20
>       60.48%  swapper  [kernel.vmlinux]  [k] intel_idle
>               54.60%
>                  intel_idle
>                  cpuidle_enter_state
>                  cpuidle_enter
>                  call_cpuidle
>                  cpu_startup_entry
>                  start_secondary
> 
>               5.88%
>                  intel_idle
>                  cpuidle_enter_state
>                  cpuidle_enter
>                  call_cpuidle
>                  cpu_startup_entry
>                  rest_init
>                  start_kernel
>                  x86_64_start_reservations
>                  x86_64_start_kernel
> 
>   $ perf report -g folded --no-children | grep -v ^# | head -3
>       60.48%  swapper  [kernel.vmlinux]  [k] intel_idle
>   54.60% intel_idle;cpuidle_enter_state;cpuidle_enter;call_cpuidle;cpu_startup_entry;start_secondary
>   5.88% intel_idle;cpuidle_enter_state;cpuidle_enter;call_cpuidle;cpu_startup_entry;rest_init;start_kernel;x86_64_start_reservations;x86_64_start_kernel
> 
> This mode is supported only for --stdio now and intended to be used by
> some scripts like in FlameGraphs[1].  Support for other UI might be
> added later.
> 
> [1] http://www.brendangregg.com/FlameGraphs/cpuflamegraphs.html
> 
> Requested-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/ui/stdio/hist.c  | 54 +++++++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/callchain.c |  6 +++++
>  tools/perf/util/callchain.h |  3 ++-
>  3 files changed, 62 insertions(+), 1 deletion(-)

missing doc update, otherwise

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  reply	other threads:[~2015-11-03  8:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  7:18 [PATCH 0/4] perf report: Support folded callchain output (v3) Namhyung Kim
2015-11-03  7:18 ` [PATCH v3 1/4] perf report: Support folded callchain mode on --stdio Namhyung Kim
2015-11-03  8:21   ` Jiri Olsa [this message]
2015-11-03  7:18 ` [PATCH v3 2/4] perf callchain: Abstract callchain print function Namhyung Kim
2015-11-03  8:40   ` Jiri Olsa
2015-11-03 10:31     ` Namhyung Kim
2015-11-03  7:18 ` [PATCH v3 3/4] perf callchain: Add count fields to struct callchain_node Namhyung Kim
2015-11-03  9:03   ` Jiri Olsa
2015-11-03  7:18 ` [PATCH v3 4/4] perf report: Add callchain value option Namhyung Kim
2015-11-03  9:04   ` Jiri Olsa
2015-11-03  9:06   ` Jiri Olsa
2015-11-03 10:53     ` Namhyung Kim
2015-11-03 11:19       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103082152.GG23878@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox