From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752609AbbKCJGr (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Nov 2015 04:06:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41342 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751054AbbKCJGc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Nov 2015 04:06:32 -0500
Date: Tue, 3 Nov 2015 10:06:27 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH v3 4/4] perf report: Add callchain value option
Message-ID: <20151103090627.GC31745@krava.brq.redhat.com>
References: <1446535111-31713-1-git-send-email-namhyung@kernel.org>
 <1446535111-31713-5-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446535111-31713-5-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 03, 2015 at 04:18:31PM +0900, Namhyung Kim wrote:

SNIP

> @@ -819,12 +837,26 @@ char *callchain_node__sprintf_value(struct callchain_node *node,
>  				    char *bf, size_t bfsize, u64 total)
>  {
>  	double percent = 0.0;
> -	u64 cumul = callchain_cumul_hits(node);
> +	u64 period = callchain_cumul_hits(node);
> +	int count = callchain_cumul_counts(node);
>  
>  	if (total)
> -		percent = cumul * 100.0 / total;
> +		percent = period * 100.0 / total;
> +	if (callchain_param.mode == CHAIN_FOLDED)
> +		count = node->count;

this could be set/computed below in respective cases

>  
> -	scnprintf(bf, bfsize, "%6.2f%%", percent);
> +	switch (callchain_param.value) {
> +	case CCVAL_PERIOD:
> +		scnprintf(bf, bfsize, "%"PRIu64, period);
> +		break;
> +	case CCVAL_COUNT:
> +		scnprintf(bf, bfsize, "%u", count);
> +		break;
> +	case CCVAL_PERCENT:
> +	default:
> +		scnprintf(bf, bfsize, "%.2f%%", percent);
> +		break;
> +	}
>  	return bf;
>  }
>  
> @@ -832,12 +864,24 @@ int callchain_node__fprintf_value(struct callchain_node *node,
>  				 FILE *fp, u64 total)
>  {
>  	double percent = 0.0;
> -	u64 cumul = callchain_cumul_hits(node);
> +	u64 period = callchain_cumul_hits(node);
> +	int count = callchain_cumul_counts(node);
>  
>  	if (total)
> -		percent = cumul * 100.0 / total;
> -
> -	return percent_color_fprintf(fp, "%.2f%%", percent);
> +		percent = period * 100.0 / total;
> +	if (callchain_param.mode == CHAIN_FOLDED)
> +		count = node->count;
> +

ditto

jirka

> +	switch (callchain_param.value) {
> +	case CCVAL_PERIOD:
> +		return fprintf(fp, "%"PRIu64, period);
> +	case CCVAL_COUNT:
> +		return fprintf(fp, "%u", count);
> +	case CCVAL_PERCENT:
> +	default:
> +		return percent_color_fprintf(fp, "%.2f%%", percent);
> +	}
> +	return 0;
>  }
>  

SNIP