public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Flush requests not going through IO scheduler
Date: Tue, 3 Nov 2015 15:55:50 +0100	[thread overview]
Message-ID: <20151103145550.GD4063@quack.suse.cz> (raw)
In-Reply-To: <x49bnbcqof9.fsf@segfault.boston.devel.redhat.com>

On Mon 02-11-15 12:52:26, Jeff Moyer wrote:
> Jan Kara <jack@suse.cz> writes:
> 
> > Hello,
> >
> > when looking into a performance issue, I've noticed one interesting thing
> > in blktrace data:
> 
> Hi Jan,
> 
> Do you have a reproducer I can run?

So I don't have a reproducer that would trigger a situation where we are
idling while there is request queued. However the following is easy to
trigger:

  8,0   67       43     0.000064884  1958  D  WS 2499459168 + 104 [jbd2/sda5-8]
  8,0   67       44     0.000222208     0  C  WS 2499459168 + 104 [0]
  8,0   67        0     0.000232553     0  m   N cfq1958SN / complete rqnoidle 1
  8,0   67        0     0.000234002     0  m   N cfq1958SN / set_slice=30
  8,0   67        0     0.000234984     0  m   N cfq1958SN / Not idling.  st->count:1
  8,0   67        0     0.000236353     0  m   N cfq1958SN / arm_idle: 2 group_idle: 1
  8,0   67        0     0.000236832     0  m   N cfq schedule dispatch
  8,0   67       45     0.000259492  1958  A FWFS 2499459272 + 8 <- (8,5) 621525192
  8,0   67       46     0.000259994  1958  Q FWFS 2499459272 + 8 [jbd2/sda5-8]
  8,0   67       47     0.000262466  1958  G FWFS 2499459272 + 8 [jbd2/sda5-8]
  8,0   67       48     0.000263164  1958  I FWFS 2499459272 + 8 [jbd2/sda5-8]
  8,0   67       49     0.000389821     0  D  WS 2499459272 + 8 [swapper/67]
  8,0   67       50     0.000439548     0  C  WS 2499459272 + 8 [0]
  8,0   67       51     0.000556711     0  C  WS 2499459272 [0]
  8,0   67        0     0.004387444     0  m   N cfq idle timer fired

Here we dispatch the flush request quickly but only because we queued kick
of the queue in IO completion of the previous request. If jbd2 were 120 us
slower in submitting the flush request, it would miss the kick and the
request would end up waiting until the idle timer fires.

To trigger this you just need a rotational storage with write back cache,
slice_idle & group_idle enabled, mount ext4 on top of it. Any trasaction
commit will end up looking like this.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2015-11-03 14:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 12:20 Flush requests not going through IO scheduler Jan Kara
2015-11-02 16:58 ` Jens Axboe
2015-11-03 16:41   ` Jan Kara
2015-11-03 16:49     ` Jens Axboe
2015-11-03 17:18       ` Jeff Moyer
2015-11-03 17:24         ` Jens Axboe
2015-11-12 13:40           ` Jan Kara
2015-11-02 17:52 ` Jeff Moyer
2015-11-03 14:55   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103145550.GD4063@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox