From: Vinod Koul <vinod.koul@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Sinan Kaya <okaya@codeaurora.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions
Date: Tue, 3 Nov 2015 21:36:22 +0530 [thread overview]
Message-ID: <20151103160622.GC12910@localhost> (raw)
In-Reply-To: <CAPcyv4gDy17WuV_f=t77v_Gw+6vihkHXpE8TRBjgnkvjZPgYEA@mail.gmail.com>
On Mon, Nov 02, 2015 at 11:44:23PM -0800, Dan Williams wrote:
> Originally ioatdma and iop-adma had local self tests before Haavard
> created dmatest. I agree having the drivers also do a test each boot
> is redundant, but then again dmatest is not automatic and I saw the
> local self test catch an interrupt setup regression.
Well the question here is not about why selftest but rather code duplication
and using same routines for both selftest as well as dmatest
>
> Maybe you could arrange for drivers to do a quick autorun through
> dmatest on load if dmatest is enabled, but otherwise load without
> testing?
That would be a good thing to do, but then most distro just enable all
config options, so this should be protected for "test" builds
> Just my 2 cents from a dmaengine spectator.
Thats an understatement :)
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
~Vinod
next prev parent reply other threads:[~2015-11-03 16:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446444460-21600-1-git-send-email-okaya@codeaurora.org>
2015-11-02 6:07 ` [PATCH V2 1/3] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2015-11-02 15:57 ` Rob Herring
2015-11-02 16:20 ` Sinan Kaya
2015-11-02 17:26 ` Timur Tabi
2015-11-02 17:42 ` Rob Herring
2015-11-02 17:48 ` Timur Tabi
2015-11-02 18:25 ` Rob Herring
2015-11-02 18:30 ` Timur Tabi
2015-11-05 14:31 ` Rob Herring
2015-11-05 14:43 ` Timur Tabi
2015-11-02 18:49 ` Sinan Kaya
2015-11-02 22:00 ` Arnd Bergmann
2015-11-03 5:18 ` Sinan Kaya
2015-11-03 10:22 ` Andy Shevchenko
2015-11-04 0:47 ` Sinan Kaya
2015-11-02 6:07 ` [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya
2015-11-03 4:15 ` Vinod Koul
2015-11-03 4:18 ` Sinan Kaya
2015-11-03 6:30 ` Vinod Koul
2015-11-03 7:44 ` Dan Williams
2015-11-03 8:22 ` Andy Shevchenko
2015-11-03 16:08 ` Vinod Koul
2015-11-05 2:42 ` Sinan Kaya
2015-11-05 12:05 ` Vinod Koul
2015-11-05 16:17 ` Sinan Kaya
2015-11-07 6:23 ` Sinan Kaya
2015-11-08 13:53 ` Vinod Koul
2015-11-13 20:20 ` okaya
2015-11-03 15:51 ` Sinan Kaya
2015-11-03 16:06 ` Vinod Koul [this message]
2015-11-03 14:31 ` Timur Tabi
2015-11-03 16:10 ` Vinod Koul
2015-11-03 16:28 ` Sinan Kaya
2015-11-03 16:46 ` Timur Tabi
2015-11-03 16:57 ` Sinan Kaya
2015-11-03 16:48 ` Timur Tabi
2015-11-02 6:07 ` [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2015-11-03 10:10 ` Andy Shevchenko
2015-11-04 0:07 ` Sinan Kaya
2015-11-04 17:44 ` Andy Shevchenko
2015-11-05 2:22 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103160622.GC12910@localhost \
--to=vinod.koul@intel.com \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox