From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jiaxing Wang <hello.wjx@gmail.com>
Subject: [for-next][PATCH 01/13] tracing: Call on_each_cpu() when adding or removing single pids from set_event_pid
Date: Tue, 03 Nov 2015 13:03:09 -0500 [thread overview]
Message-ID: <20151103180347.706906338@goodmis.org> (raw)
In-Reply-To: 20151103180308.542651732@goodmis.org
[-- Attachment #1: 0001-tracing-Call-on_each_cpu-when-adding-or-removing-sin.patch --]
[-- Type: text/plain, Size: 1425 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
For the case where pids are already in set_event_pid, and one is added or
removed then each CPU should be checked to make sure that the new or old pid
is on or not on a CPU.
For example:
# echo 123 >> set_event_pid
or
# echo '!123' >> set_event_pid
Link: http://lkml.kernel.org/r/20151030061643.GA19480@cac
Suggested-by: Jiaxing Wang <hello.wjx@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index fb0261e90acc..292bccf3e011 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1729,14 +1729,15 @@ ftrace_event_pid_write(struct file *filp, const char __user *ubuf,
tr, INT_MAX);
register_trace_prio_sched_wakeup(event_filter_pid_sched_wakeup_probe_post,
tr, 0);
-
- /*
- * Ignoring of pids is done at task switch. But we have to
- * check for those tasks that are currently running.
- */
- on_each_cpu(ignore_task_cpu, tr, 1);
}
+ /*
+ * Ignoring of pids is done at task switch. But we have to
+ * check for those tasks that are currently running.
+ * Always do this in case a pid was appended or removed.
+ */
+ on_each_cpu(ignore_task_cpu, tr, 1);
+
mutex_unlock(&event_mutex);
ret = read;
--
2.6.1
next prev parent reply other threads:[~2015-11-03 18:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 18:03 [for-next][PATCH 00/13] tracing: Minor updates and fixes for 4.4 Steven Rostedt
2015-11-03 18:03 ` Steven Rostedt [this message]
2015-11-03 18:03 ` [for-next][PATCH 02/13] recordmcount: x86: Assign a meaningful value to rel_type_nop Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 03/13] tracing: Only benchmark the time tracepoints take if tracing is on Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 04/13] tracing: Update instance_rmdir() to use tracefs_remove_recursive Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 05/13] Sample: Trace_event: Correct the comments Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 06/13] tracing: report_latency() in trace_sched_wakeup.c can return boolean Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 07/13] tracing: report_latency() in trace_irqsoff.c " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 08/13] ring-buffer: rb_is_reader_page() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 09/13] ring_buffer: ring_buffer_empty{cpu}() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 10/13] ring-buffer: rb_per_cpu_empty() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 11/13] ring-buffer: rb_event_is_commit() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 12/13] tracing: is_legal_op() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 13/13] tracing: ftrace_event_is_function() " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103180347.706906338@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hello.wjx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox