public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yaowei Bai <bywxiaobai@163.com>
Subject: [for-next][PATCH 10/13] ring-buffer: rb_per_cpu_empty() can return boolean
Date: Tue, 03 Nov 2015 13:03:18 -0500	[thread overview]
Message-ID: <20151103180349.226812961@goodmis.org> (raw)
In-Reply-To: 20151103180308.542651732@goodmis.org

[-- Attachment #1: 0010-ring-buffer-rb_per_cpu_empty-can-return-boolean.patch --]
[-- Type: text/plain, Size: 1223 bytes --]

From: Yaowei Bai <bywxiaobai@163.com>

Makes rb_per_cpu_empty() return bool to improve readability.

No functional change.

Link: http://lkml.kernel.org/r/1443537816-5788-6-git-send-email-bywxiaobai@163.com

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ring_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index fc9ce12666be..a22878923a30 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -3039,7 +3039,7 @@ int ring_buffer_write(struct ring_buffer *buffer,
 }
 EXPORT_SYMBOL_GPL(ring_buffer_write);
 
-static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
+static bool rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
 {
 	struct buffer_page *reader = cpu_buffer->reader_page;
 	struct buffer_page *head = rb_set_head_page(cpu_buffer);
@@ -3047,7 +3047,7 @@ static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
 
 	/* In case of error, head will be NULL */
 	if (unlikely(!head))
-		return 1;
+		return true;
 
 	return reader->read == rb_page_commit(reader) &&
 		(commit == reader ||
-- 
2.6.1



  parent reply	other threads:[~2015-11-03 18:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 18:03 [for-next][PATCH 00/13] tracing: Minor updates and fixes for 4.4 Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 01/13] tracing: Call on_each_cpu() when adding or removing single pids from set_event_pid Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 02/13] recordmcount: x86: Assign a meaningful value to rel_type_nop Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 03/13] tracing: Only benchmark the time tracepoints take if tracing is on Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 04/13] tracing: Update instance_rmdir() to use tracefs_remove_recursive Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 05/13] Sample: Trace_event: Correct the comments Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 06/13] tracing: report_latency() in trace_sched_wakeup.c can return boolean Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 07/13] tracing: report_latency() in trace_irqsoff.c " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 08/13] ring-buffer: rb_is_reader_page() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 09/13] ring_buffer: ring_buffer_empty{cpu}() " Steven Rostedt
2015-11-03 18:03 ` Steven Rostedt [this message]
2015-11-03 18:03 ` [for-next][PATCH 11/13] ring-buffer: rb_event_is_commit() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 12/13] tracing: is_legal_op() " Steven Rostedt
2015-11-03 18:03 ` [for-next][PATCH 13/13] tracing: ftrace_event_is_function() " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103180349.226812961@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=bywxiaobai@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox