From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbbKDIfS (ORCPT ); Wed, 4 Nov 2015 03:35:18 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34754 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbbKDIfP (ORCPT ); Wed, 4 Nov 2015 03:35:15 -0500 Date: Wed, 4 Nov 2015 17:36:10 +0900 From: Sergey Senozhatsky To: yalin wang Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, mgorman@suse.de, hannes@cmpxchg.org, riel@redhat.com, raindel@mellanox.com, willy@linux.intel.com, boaz@plexistor.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: change tlb_finish_mmu() to be more simple Message-ID: <20151104083610.GA403@swordfish> References: <1446622531-316-1-git-send-email-yalin.wang2010@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446622531-316-1-git-send-email-yalin.wang2010@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (11/04/15 15:35), yalin wang wrote: [..] > > - for (batch = tlb->local.next; batch; batch = next) { > - next = batch->next; > + for (batch = tlb->local.next; batch; batch = batch->next) > free_pages((unsigned long)batch, 0); accessing `batch->next' after calling free_pages() on `batch'? -ss