Re: [PATCH 4/4] locking: Introduce smp_cond_acquire()

Paul E. McKenney
2015-11-12T15:03:03Z

On Thu, Nov 12, 2015 at 03:50:13PM +0100, Peter Zijlstra wrote:
> On Thu, Nov 12, 2015 at 06:40:04AM -0800, Paul E. McKenney wrote:
> > I cannot resist suggesting that any lock that interacts with
> > spin_unlock_wait() must have all relevant acquisitions followed by
> > smp_mb__after_unlock_lock().
>
> Ha! that would certainly help here. But it would mean that argh64v8 also
> needs to define that, even though that is already RCsc.

Maybe. It could also be that arm64 avoids the need somehow, for example
via their RCsc behavior. Their memory model is similar to PPC, but not
exactly the same.

Will?

Thanx, Paul