public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>,
	Seth Jennings <sjenning@redhat.com>,
	Vojtech Pavlik <vojtech@suse.com>,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	"Cyril B." <cbay@alwaysdata.com>
Subject: Re: [PATCH] livepatch: Cleanup page permission changes
Date: Wed, 4 Nov 2015 10:13:47 -0600	[thread overview]
Message-ID: <20151104161347.GC29899@treble.redhat.com> (raw)
In-Reply-To: <20151104161006.GB29899@treble.redhat.com>

On Wed, Nov 04, 2015 at 10:10:06AM -0600, Josh Poimboeuf wrote:
> On Wed, Nov 04, 2015 at 10:18:29AM +0100, Jiri Kosina wrote:
> > On Tue, 3 Nov 2015, Josh Poimboeuf wrote:
> > 
> > > It's probably a good idea to keep the patches bisectable, so I made this
> > > a separate patch which applies on top of the first one.
> > > 
> > > (Note that it completely removes all the code from the first patch, so
> > > there's no need for a v2 of the first patch which would have had
> > > Miroslav's suggested style changes.)
> > 
> > I like this patch and it's something I'd like to queue for 4.4, but given 
> > the fact that the original "[PATCH] x86/livepatch: Fix crash with 
> > !CONFIG_DEBUG_SET_MODULE_RONX" wasn't queued in any tree yet, I don't 
> > think that sending it as a followup patch is of any use.
> > 
> > So if you agree, I'll just fold the two patches together and use the 
> > changelog below, and queue it for merge with Linus.
> 
> I kept them separate because the first patch is a low risk bug fix, and
> the second is a slightly higher risk cleanup.
> 
> Would it make sense to put the first one into 4.4 and queue the second
> one for 4.5?

BTW, the second one is still pretty low risk, so it's fine with me if
you decide you still want to squash them for 4.4.

-- 
Josh

  reply	other threads:[~2015-11-04 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 20:00 [PATCH] x86/livepatch: Fix crash with !CONFIG_DEBUG_SET_MODULE_RONX Josh Poimboeuf
2015-11-03 10:22 ` Miroslav Benes
2015-11-03 15:22   ` Josh Poimboeuf
2015-11-03 17:42   ` [PATCH] livepatch: Cleanup page permission changes Josh Poimboeuf
2015-11-04  9:18     ` Jiri Kosina
2015-11-04 16:10       ` Josh Poimboeuf
2015-11-04 16:13         ` Josh Poimboeuf [this message]
2015-11-04  9:40     ` Miroslav Benes
2015-11-04 22:56     ` Jiri Kosina
2015-11-04 23:12       ` Josh Poimboeuf
2015-11-05  9:28         ` Jiri Kosina
2015-11-05  9:40           ` Jiri Kosina
2015-11-05 15:17             ` Josh Poimboeuf
2015-11-05 17:33               ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104161347.GC29899@treble.redhat.com \
    --to=jpoimboe@redhat.com \
    --cc=cbay@alwaysdata.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox