From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756323AbbKDSX5 (ORCPT ); Wed, 4 Nov 2015 13:23:57 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:31381 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756300AbbKDSX4 (ORCPT ); Wed, 4 Nov 2015 13:23:56 -0500 Date: Wed, 4 Nov 2015 21:23:43 +0300 From: Dan Carpenter To: Joe Perches Cc: Alex Williamson , Frank Blaschka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] vfio: make an array larger Message-ID: <20151104182343.GO18797@mwanda> References: <20151104132624.GC20966@mwanda> <1446655219.21133.48.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446655219.21133.48.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2015 at 08:40:19AM -0800, Joe Perches wrote: > Doesn't the same thing happen with pci_ext_cap_length? pci_ext_cap_length is fine as-is but you're right that we probably should make the size explicit as well. I will fix and resend. > Both array declarations might be better as const. Sure. I will do this as well. regards, dan carpenter