From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031369AbbKDSyp (ORCPT ); Wed, 4 Nov 2015 13:54:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42980 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030453AbbKDSyo (ORCPT ); Wed, 4 Nov 2015 13:54:44 -0500 Date: Wed, 4 Nov 2015 10:54:42 -0800 From: Greg Kroah-Hartman To: Steven Rostedt Cc: Jiaxing Wang , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not compiled or initialized. Message-ID: <20151104185442.GA19152@kroah.com> References: <20151102091637.0fcc05b2@gandalf.local.home> <1446599478-8723-1-git-send-email-hello.wjx@gmail.com> <20151104100339.583e1bc9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151104100339.583e1bc9@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2015 at 10:03:39AM -0500, Steven Rostedt wrote: > On Wed, 4 Nov 2015 09:11:18 +0800 > Jiaxing Wang wrote: > > > Currently tracing_init_dentry() returns -ENODEV when debugfs is not > > initialized, which causes tracefs not populated with tracing files and > > directories, so we will get an empty directory even after we manually > > mount tracefs. > > > > We can make tracing_init_dentry() return NULL as long as tracefs > > is initialized and get a populated tracefs. > > > > We also need to make global_trace.dir not NULL in order to pass the checks > > in tracing_get_dentry() and add_tracer_options(). > > > > Also added stub debugfs_create_automount() for when debugfs is not > > configured in. The debugfs change should be split out into a separate patch, which I'll be glad to take through my tree, it isn't dependant on the tracing code at all. thanks, greg k-h