linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>
Subject: Re: [GIT PULL] x86/mm changes for v4.4
Date: Wed, 4 Nov 2015 18:39:07 -0500	[thread overview]
Message-ID: <20151104233907.GA25925@codemonkey.org.uk> (raw)
In-Reply-To: <CA+55aFzcwO+RSLeHOwAYvjZ5AcVvD9Th2=G3R=ZQY1xf+MkDow@mail.gmail.com>

On Wed, Nov 04, 2015 at 11:26:12AM -0800, Linus Torvalds wrote:
 > On Tue, Nov 3, 2015 at 3:16 AM, Ingo Molnar <mingo@kernel.org> wrote:
 > >
 > > The new CONFIG_DEBUG_WX=y warning is marked default-y if CONFIG_DEBUG_RODATA=y is
 > > already eanbled, as a special exception, as these bugs are hard to notice and this
 > > check already found several live bugs.
 > 
 > So this seems to be not very useful.
 > 
 >   ...
 >   Freeing unused kernel memory: 1068K (ffffffff8bcc0000 -
 > ffffffff8bdcb000)
 >   Write protecting the kernel read-only data: 12288k
 >   Freeing unused kernel memory: 1944K (ffff88000b61a000 - ffff88000b800000)
 >   Freeing unused kernel memory: 1372K (ffff88000baa9000 - ffff88000bc00000)
 >   ------------[ cut here ]------------
 >   WARNING: CPU: 7 PID: 1 at arch/x86/mm/dump_pagetables.c:225
 > note_page+0x5dc/0x780()
 >   x86/mm: Found insecure W+X mapping at address
 > ffff88000005f000/0xffff88000005f000
 >   ...
 >   x86/mm: Checked W+X mappings: FAILED, 165660 W+X pages found.
 >   ...
 > 
 > because it doesn't seem to give you any idea where to look for the
 > issue. Those 165660 pages come out to 647MB. Odd number.
 > 
 > Is this *supposed* to come out clean?

FWIW I'm seeing this too.

[    3.293503] x86/mm: Found insecure W+X mapping at address ffff880000800000/0xffff880000800000

Looking further up the dmesg I see that range is..

[    0.468368] ---[ Low Kernel Mapping ]---
[    0.468381] 0xffff880000000000-0xffff880000800000           8M     RW                 GLB NX pte
[    0.468391] 0xffff880000800000-0xffff880000900000           1M     RW                 GLB x  pte

Linus, does that match your trace too ? The 2nd low kernel mapping?

	Dave

  reply	other threads:[~2015-11-04 23:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 11:16 [GIT PULL] x86/mm changes for v4.4 Ingo Molnar
2015-11-04 19:26 ` Linus Torvalds
2015-11-04 23:39   ` Dave Jones [this message]
2015-11-05  1:31     ` Linus Torvalds
2015-11-05  2:17       ` Dave Jones
2015-11-05 21:27         ` Linus Torvalds
2015-11-05 21:33           ` Linus Torvalds
2015-11-06 11:39             ` Matt Fleming
2015-11-07  7:05               ` Ingo Molnar
2015-11-07 10:03                 ` Matt Fleming
2015-11-05 22:04           ` Linus Torvalds
2015-11-05 22:27             ` Borislav Petkov
2015-11-06  6:55           ` Ingo Molnar
2015-11-06  7:05             ` Andy Lutomirski
2015-11-06 13:09               ` Matt Fleming
2015-11-06 13:24                 ` Borislav Petkov
2015-11-07  7:03               ` Ingo Molnar
2015-11-06  7:44             ` Ingo Molnar
2015-11-06 12:39             ` Matt Fleming
2015-11-07  7:09               ` Ingo Molnar
2015-11-07  7:39                 ` Ard Biesheuvel
2015-11-08  6:58                   ` Kees Cook
2015-11-08  7:55                     ` Ard Biesheuvel
2015-11-09 21:08                       ` Kees Cook
2015-11-10  7:08                         ` Ard Biesheuvel
2015-11-10 20:11                           ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104233907.GA25925@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).