From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161347AbbKEOFi (ORCPT ); Thu, 5 Nov 2015 09:05:38 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48394 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030850AbbKEOFg (ORCPT ); Thu, 5 Nov 2015 09:05:36 -0500 Date: Thu, 5 Nov 2015 14:04:12 +0000 From: Mark Brown To: Chen Feng Cc: w.f@huawei.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, joro@8bytes.org, iommu@lists.linux-foundation.org, haojian.zhuang@linaro.org, devicetree@vger.kernel.org, xuwei5@hisilicon.com, xuyiping@hisilicon.com, kong.kongxinwei@hisilicon.com, z.liuxinliang@hisilicon.com, yudongbin@hisilicon.com, weidong2@hisilicon.com, saberlily.xia@hisilicon.com, haojian.zhuang@outlook.com, leo.yan@linaro.org, linuxarm@huawei.com, dan.zhao@hisilicon.com, peter.panshilin@hisilicon.com, qijiwen@hisilicon.com Message-ID: <20151105140412.GG18409@sirena.org.uk> References: <1446730488-31930-1-git-send-email-puck.chen@hisilicon.com> <1446730488-31930-2-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E69HUUNAyIJqGpVn" Content-Disposition: inline In-Reply-To: <1446730488-31930-2-git-send-email-puck.chen@hisilicon.com> X-Cookie: Put your trust in those who are worthy. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 92.40.249.56 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --E69HUUNAyIJqGpVn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote: Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. > +- #interrupt-cells: Should be 2, two cells are needed for irq. > +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain). > +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x. I'm not entirely sure what this is but it sounds worrying - why can you not just use a normal interrupt specifier? It also doesn't correspond to the example: > +Example: > + pmic: pmic@f8000000 { > + compatible =3D "hisilicon,hi655x-pmic-driver"; > + reg =3D <0x0 0xf8000000 0x0 0x1000>; > + #interrupt-cells =3D <2>; > + interrupt-controller; > + pmic_gpios =3D <&gpio_pmu_irq_n>; > + status =3D "okay"; > + } > --=20 > 1.9.1 >=20 >=20 --E69HUUNAyIJqGpVn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWO2HYAAoJECTWi3JdVIfQwakH/AtaBrA8Y1kDas7nFl58D4BM /HpHYZJvu0WHdTs+z5oAdUTrREuA2wo3voXb4Er7q6TpE8ZsMbc3/e0pirvogEUP 4rPHRCo0Nn8XoGopVK9zLSohyJbeB2EO80KIPE2yu+trMl89Ol5twjiVMyEVHPtH H9ASxS5kinz1avedj/1y9IxP0kPc+FTAe42D645GzpfqH4PJ65dPk8AyLVt+B0ry InWia+Sy/3oEGTwZV5YfHyV6GnVnYHyfKcWrPs3p8il72cjVWW9h29GWN0RRu9tE 8mJnTQQCGKhJsY7l0MhyfFLNCf6fdneUpu8hsKJxFSGlD+yKhk6yR3OgjzK5zmg= =BkIs -----END PGP SIGNATURE----- --E69HUUNAyIJqGpVn--