public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Ulrich Obergfell <uobergfe@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	atomlin@redhat.com
Subject: Re: [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry)
Date: Thu, 5 Nov 2015 09:46:00 -0500	[thread overview]
Message-ID: <20151105144600.GE209762@redhat.com> (raw)
In-Reply-To: <1446564061-3379-1-git-send-email-uobergfe@redhat.com>

On Tue, Nov 03, 2015 at 04:20:57PM +0100, Ulrich Obergfell wrote:
> This patch set addresses various races in relation to CPU hotplug
> and a race in relation to watchdog timer expiry. I discovered the
> corner cases during code inspection. I haven't seen any of these
> issues occur in practice.

Series looks fine to me.  I have run some local panic tests with no
problems, along with modifying various values and everything seems fine.

Acked-by: Don Zickus <dzickus@redhat.com>

> 
> Ulrich Obergfell (4):
>   watchdog: avoid race between lockup detector suspend/resume and CPU
>     hotplug
>   watchdog: avoid races between /proc handlers and CPU hotplug
>   watchdog: remove {get|put}_online_cpus() from
>     watchdog_{park|unpark}_threads()
>   watchdog: fix race between proc_watchdog_thresh() and
>     watchdog_timer_fn()
> 
>  kernel/watchdog.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> -- 
> 1.7.11.7
> 

  parent reply	other threads:[~2015-11-05 14:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 15:20 [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry) Ulrich Obergfell
2015-11-03 15:20 ` [PATCH 1/4] watchdog: avoid race between lockup detector suspend/resume and CPU hotplug Ulrich Obergfell
2015-11-03 15:20 ` [PATCH 2/4] watchdog: avoid races between /proc handlers " Ulrich Obergfell
2015-11-03 15:21 ` [PATCH 3/4] watchdog: remove {get|put}_online_cpus() from watchdog_{park|unpark}_threads() Ulrich Obergfell
2015-11-03 15:21 ` [PATCH 4/4] watchdog: fix race between proc_watchdog_thresh() and watchdog_timer_fn() Ulrich Obergfell
2015-11-05 14:46 ` Don Zickus [this message]
2015-11-05 20:50 ` [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry) Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105144600.GE209762@redhat.com \
    --to=dzickus@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox