From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162285AbbKEOqG (ORCPT ); Thu, 5 Nov 2015 09:46:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48829 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161427AbbKEOqB (ORCPT ); Thu, 5 Nov 2015 09:46:01 -0500 Date: Thu, 5 Nov 2015 09:46:00 -0500 From: Don Zickus To: Ulrich Obergfell Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, atomlin@redhat.com Subject: Re: [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry) Message-ID: <20151105144600.GE209762@redhat.com> References: <1446564061-3379-1-git-send-email-uobergfe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446564061-3379-1-git-send-email-uobergfe@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 03, 2015 at 04:20:57PM +0100, Ulrich Obergfell wrote: > This patch set addresses various races in relation to CPU hotplug > and a race in relation to watchdog timer expiry. I discovered the > corner cases during code inspection. I haven't seen any of these > issues occur in practice. Series looks fine to me. I have run some local panic tests with no problems, along with modifying various values and everything seems fine. Acked-by: Don Zickus > > Ulrich Obergfell (4): > watchdog: avoid race between lockup detector suspend/resume and CPU > hotplug > watchdog: avoid races between /proc handlers and CPU hotplug > watchdog: remove {get|put}_online_cpus() from > watchdog_{park|unpark}_threads() > watchdog: fix race between proc_watchdog_thresh() and > watchdog_timer_fn() > > kernel/watchdog.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > -- > 1.7.11.7 >