From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbbKEUbl (ORCPT ); Thu, 5 Nov 2015 15:31:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:60152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbbKEUbj (ORCPT ); Thu, 5 Nov 2015 15:31:39 -0500 Date: Thu, 5 Nov 2015 14:31:33 -0600 From: Rob Herring To: Chen Feng Cc: w.f@huawei.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, joro@8bytes.org, iommu@lists.linux-foundation.org, haojian.zhuang@linaro.org, devicetree@vger.kernel.org, xuwei5@hisilicon.com, xuyiping@hisilicon.com, kong.kongxinwei@hisilicon.com, z.liuxinliang@hisilicon.com, yudongbin@hisilicon.com, weidong2@hisilicon.com, saberlily.xia@hisilicon.com, haojian.zhuang@outlook.com, leo.yan@linaro.org, linuxarm@huawei.com, dan.zhao@hisilicon.com, peter.panshilin@hisilicon.com, qijiwen@hisilicon.com Subject: Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC Message-ID: <20151105203133.GA9152@rob-hp-laptop> References: <1446730488-31930-1-git-send-email-puck.chen@hisilicon.com> <1446730488-31930-3-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446730488-31930-3-git-send-email-puck.chen@hisilicon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote: > Add Document for mtcmos driver on hi6220 SoC > > Signed-off-by: Chen Feng > Signed-off-by: Fei Wang > --- > .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > > diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > new file mode 100644 > index 0000000..bb06e1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > @@ -0,0 +1,32 @@ > +Hi6220 mtcmos Voltage regulators > + > +Required parent device properties: > +- compatible: Must be "hisilicon,hi6220-mtcmos-driver" What does "driver" refer to? > +- hisilicon,mtcmos-steady-us: The time to wait for power steady Wouldn't regulator-enable-ramp-delay be equivalent? > +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC > + > +Required child device properties: > +- regulator-name: The name of mtcmos > +- hisilicon,ctrl-regs: Offset of ctrl-regs > +- hisilicon,ctrl-data: The bit to ctrl the regulator > + > +Example: > + mtcmos { > + compatible = "hisilicon,hi6220-mtcmos-driver"; > + hisilicon,mtcmos-steady-us = <10>; > + hisilicon,mtcmos-sc-on-base = <0xf7800000>; > + hisilicon,mtcmos-acpu-on-base = <0xf65a0000>; > + > + mtcmos1: regulator@a1{ > + regulator-name = "G3D_PD_VDD"; > + regulator-compatible = "mtcmos1"; regulator-compatible is deprecated. Please drop. > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <1 0x1>; > + }; > + mtcmos2: regulator@a2{ > + regulator-name = "SOC_MED"; > + regulator-compatible = "mtcmos2"; > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <2 0x1>; > + }; > + }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html