Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

Mark Brown
2015-11-05T14:14:38Z

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote:

> +- hisilicon,mtcmos-steady-us: The time to wait for power steady
> +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
> +
> +Required child device properties:
> +- regulator-name: The name of mtcmos
> +- hisilicon,ctrl-regs: Offset of ctrl-regs
> +- hisilicon,ctrl-data: The bit to ctrl the regulator

This doesn't look like a regulator binding at all... for one thing
there's no reference to the generic regulator bindings, and having a
mandatory regulator-name seems like there's a problem somewhere.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]