Re: [PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC

Mark Brown
2015-11-05T14:05:38Z

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote:

Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.

> +- #interrupt-cells: Should be 2, two cells are needed for irq.
> +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain).
> +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x.

I'm not entirely sure what this is but it sounds worrying - why can you
not just use a normal interrupt specifier? It also doesn't correspond
to the example:

> +Example:
> + pmic: pmic@f8000000 {
> + compatible = "hisilicon,hi655x-pmic-driver";
> + reg = <0x0 0xf8000000 0x0 0x1000>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + pmic_gpios = <&gpio_pmu_irq_n>;
> + status = "okay";
> + }
> --
> 1.9.1
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]