Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

Wolfram Sang
2015-12-01T00:43:22Z

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> >
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> >
>
> I see, how about change if statement to else if?

That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]