public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: Andy Gross <agross@codeaurora.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB
Date: Fri, 6 Nov 2015 16:24:31 +0800	[thread overview]
Message-ID: <20151106082429.GA569@shlinux2> (raw)
In-Reply-To: <1446789847-640-2-git-send-email-agross@codeaurora.org>

On Fri, Nov 06, 2015 at 12:04:06AM -0600, Andy Gross wrote:
> This patch sets the AHBMODE to allow for posted data writes.  This
> results in higher performance.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index d79ecc0..3889809 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -25,7 +25,8 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
>  	case CI_HDRC_CONTROLLER_RESET_EVENT:
>  		dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n");
>  		writel(0, USB_AHBBURST);
> -		writel(0, USB_AHBMODE);
> +		/* use AHB transactor, allow posted data writes */
> +		writel(0x8, USB_AHBMODE);
>  		usb_phy_init(ci->usb_phy);
>  		break;
>  	case CI_HDRC_CONTROLLER_STOPPED_EVENT:
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

Greg, another related changes is at host driver, pick it up
directly please, thanks.

Acked-by: Peter Chen <peter.chen@freescale.com>

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2015-11-06  8:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:04 [PATCH 0/2] Configure AHB to post data transfers Andy Gross
2015-11-06  6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross
2015-11-06  8:24   ` Peter Chen [this message]
2015-11-06  6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross
2015-11-06 10:13   ` Georgi Djakov
2015-11-06 15:41     ` Alan Stern
2015-12-10 17:51   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151106082429.GA569@shlinux2 \
    --to=peter.chen@freescale.com \
    --cc=agross@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox