* [PATCH 0/2] Configure AHB to post data transfers @ 2015-11-06 6:04 Andy Gross 2015-11-06 6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross 2015-11-06 6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross 0 siblings, 2 replies; 7+ messages in thread From: Andy Gross @ 2015-11-06 6:04 UTC (permalink / raw) To: linux-usb Cc: Greg KH, Peter Chen, Alan Stern, linux-kernel, linux-arm-msm, Andy Gross This patch configures the ChipIdea USB 2.0 controller found on Qualcomm platforms to post data transfers on the AHB bus. This yields approximately a 50% increase in performance. Andy Gross (2): usb: chipidea: msm: Use posted data writes on AHB usb: host: ehci-msm: Use posted data writes on AHB drivers/usb/chipidea/ci_hdrc_msm.c | 3 ++- drivers/usb/host/ehci-msm.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB 2015-11-06 6:04 [PATCH 0/2] Configure AHB to post data transfers Andy Gross @ 2015-11-06 6:04 ` Andy Gross 2015-11-06 8:24 ` Peter Chen 2015-11-06 6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross 1 sibling, 1 reply; 7+ messages in thread From: Andy Gross @ 2015-11-06 6:04 UTC (permalink / raw) To: linux-usb Cc: Greg KH, Peter Chen, Alan Stern, linux-kernel, linux-arm-msm, Andy Gross This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross <agross@codeaurora.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index d79ecc0..3889809 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -25,7 +25,8 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) case CI_HDRC_CONTROLLER_RESET_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); writel(0, USB_AHBBURST); - writel(0, USB_AHBMODE); + /* use AHB transactor, allow posted data writes */ + writel(0x8, USB_AHBMODE); usb_phy_init(ci->usb_phy); break; case CI_HDRC_CONTROLLER_STOPPED_EVENT: -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB 2015-11-06 6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross @ 2015-11-06 8:24 ` Peter Chen 0 siblings, 0 replies; 7+ messages in thread From: Peter Chen @ 2015-11-06 8:24 UTC (permalink / raw) To: Andy Gross, Greg KH; +Cc: linux-usb, Alan Stern, linux-kernel, linux-arm-msm On Fri, Nov 06, 2015 at 12:04:06AM -0600, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross <agross@codeaurora.org> > --- > drivers/usb/chipidea/ci_hdrc_msm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c > index d79ecc0..3889809 100644 > --- a/drivers/usb/chipidea/ci_hdrc_msm.c > +++ b/drivers/usb/chipidea/ci_hdrc_msm.c > @@ -25,7 +25,8 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) > case CI_HDRC_CONTROLLER_RESET_EVENT: > dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); > writel(0, USB_AHBBURST); > - writel(0, USB_AHBMODE); > + /* use AHB transactor, allow posted data writes */ > + writel(0x8, USB_AHBMODE); > usb_phy_init(ci->usb_phy); > break; > case CI_HDRC_CONTROLLER_STOPPED_EVENT: > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > Greg, another related changes is at host driver, pick it up directly please, thanks. Acked-by: Peter Chen <peter.chen@freescale.com> -- Best Regards, Peter Chen ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB 2015-11-06 6:04 [PATCH 0/2] Configure AHB to post data transfers Andy Gross 2015-11-06 6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross @ 2015-11-06 6:04 ` Andy Gross 2015-11-06 10:13 ` Georgi Djakov 2015-12-10 17:51 ` Timur Tabi 1 sibling, 2 replies; 7+ messages in thread From: Andy Gross @ 2015-11-06 6:04 UTC (permalink / raw) To: linux-usb Cc: Greg KH, Peter Chen, Alan Stern, linux-kernel, linux-arm-msm, Andy Gross This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross <agross@codeaurora.org> --- drivers/usb/host/ehci-msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index c4f84c8..c23e285 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) /* bursts of unspecified length. */ writel(0, USB_AHBBURST); - /* Use the AHB transactor */ - writel(0, USB_AHBMODE); + /* Use the AHB transactor, allow posted data writes */ + writel(0x8, USB_AHBMODE); /* Disable streaming mode and select host mode */ writel(0x13, USB_USBMODE); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB 2015-11-06 6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross @ 2015-11-06 10:13 ` Georgi Djakov 2015-11-06 15:41 ` Alan Stern 2015-12-10 17:51 ` Timur Tabi 1 sibling, 1 reply; 7+ messages in thread From: Georgi Djakov @ 2015-11-06 10:13 UTC (permalink / raw) To: Andy Gross, linux-usb Cc: Greg KH, Peter Chen, Alan Stern, linux-kernel, linux-arm-msm On 11/06/2015 08:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross <agross@codeaurora.org> With these patches I see significant improvement in throughput on my db410c board. Tested-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > drivers/usb/host/ehci-msm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > index c4f84c8..c23e285 100644 > --- a/drivers/usb/host/ehci-msm.c > +++ b/drivers/usb/host/ehci-msm.c > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > /* bursts of unspecified length. */ > writel(0, USB_AHBBURST); > - /* Use the AHB transactor */ > - writel(0, USB_AHBMODE); > + /* Use the AHB transactor, allow posted data writes */ > + writel(0x8, USB_AHBMODE); > /* Disable streaming mode and select host mode */ > writel(0x13, USB_USBMODE); > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB 2015-11-06 10:13 ` Georgi Djakov @ 2015-11-06 15:41 ` Alan Stern 0 siblings, 0 replies; 7+ messages in thread From: Alan Stern @ 2015-11-06 15:41 UTC (permalink / raw) To: Georgi Djakov Cc: Andy Gross, linux-usb, Greg KH, Peter Chen, linux-kernel, linux-arm-msm On Fri, 6 Nov 2015, Georgi Djakov wrote: > On 11/06/2015 08:04 AM, Andy Gross wrote: > > This patch sets the AHBMODE to allow for posted data writes. This > > results in higher performance. > > > > Signed-off-by: Andy Gross <agross@codeaurora.org> > > With these patches I see significant improvement in throughput > on my db410c board. > > Tested-by: Georgi Djakov <georgi.djakov@linaro.org> > > > --- > > drivers/usb/host/ehci-msm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > > index c4f84c8..c23e285 100644 > > --- a/drivers/usb/host/ehci-msm.c > > +++ b/drivers/usb/host/ehci-msm.c > > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > > > /* bursts of unspecified length. */ > > writel(0, USB_AHBBURST); > > - /* Use the AHB transactor */ > > - writel(0, USB_AHBMODE); > > + /* Use the AHB transactor, allow posted data writes */ > > + writel(0x8, USB_AHBMODE); > > /* Disable streaming mode and select host mode */ > > writel(0x13, USB_USBMODE); Acked-by: Alan Stern <stern@rowland.harvard.edu> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB 2015-11-06 6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross 2015-11-06 10:13 ` Georgi Djakov @ 2015-12-10 17:51 ` Timur Tabi 1 sibling, 0 replies; 7+ messages in thread From: Timur Tabi @ 2015-12-10 17:51 UTC (permalink / raw) To: Andy Gross Cc: linux-usb, Greg KH, Peter Chen, Alan Stern, lkml, linux-arm-msm On Fri, Nov 6, 2015 at 12:04 AM, Andy Gross <agross@codeaurora.org> wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross <agross@codeaurora.org> I know it's a little late, but ... Acked-by: Timur Tabi <timur@codeaurora.org> -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-10 17:51 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-06 6:04 [PATCH 0/2] Configure AHB to post data transfers Andy Gross 2015-11-06 6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross 2015-11-06 8:24 ` Peter Chen 2015-11-06 6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross 2015-11-06 10:13 ` Georgi Djakov 2015-11-06 15:41 ` Alan Stern 2015-12-10 17:51 ` Timur Tabi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox