Re: [PATCH 04/10] pwm: core: use bitops

Thierry Reding
2015-11-06T14:46:40Z

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote:
> From: Olliver Schinagl <oliver@schinagl.nl>
>
> The pwm header defines bits manually while there is a nice bitops.h with
> a BIT() macro. Use the BIT() macro to set bits in pwm.h
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> include/linux/pwm.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

I don't think this is a useful change. The BIT() macro needs the same
number of characters to type at the expense of requiring an additional
include.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]