From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbbKGOuT (ORCPT ); Sat, 7 Nov 2015 09:50:19 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:58294 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753385AbbKGOuR (ORCPT ); Sat, 7 Nov 2015 09:50:17 -0500 Date: Sat, 07 Nov 2015 09:50:13 -0500 (EST) Message-Id: <20151107.095013.902059569721693135.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: lars.persson@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() From: David Miller In-Reply-To: <563E077C.3090201@users.sourceforge.net> References: <563C5392.6030309@users.sourceforge.net> <20151106.233311.2260896695923603885.davem@davemloft.net> <563E077C.3090201@users.sourceforge.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Nov 2015 06:50:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Sat, 7 Nov 2015 15:15:24 +0100 > From: Markus Elfring > Date: Sat, 7 Nov 2015 15:10:29 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring As I requested of you last night, please phrase the subsystem prefix of your Subject lines more correctly. Just use the driver's name, in lower case, as one single word, which in this case would be "dwc_eth_qos: ". I'm telling you exactly what to use in the Subject line, there is no ambiguity or confusion on what you need to do for me to accept this patch. Thanks.