From: Matt Fleming <matt@codeblueprint.co.uk>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range
Date: Sat, 7 Nov 2015 09:43:06 +0000 [thread overview]
Message-ID: <20151107094306.GA2387@codeblueprint.co.uk> (raw)
In-Reply-To: <20151106141139.GA2233@shrek.podlesie.net>
On Fri, 06 Nov, at 03:11:39PM, Krzysztof Mazur wrote:
> On Fri, Nov 06, 2015 at 02:27:33PM +0100, Borislav Petkov wrote:
> > On Fri, Nov 06, 2015 at 02:18:36PM +0100, Krzysztof Mazur wrote:
> > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > > index a3cccbf..37c8ea8 100644
> > > --- a/arch/x86/kernel/setup.c
> > > +++ b/arch/x86/kernel/setup.c
> > > @@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
> > > */
> > > clone_pgd_range(initial_page_table,
> > > swapper_pg_dir + KERNEL_PGD_BOUNDARY,
> > > - KERNEL_PGD_PTRS);
> > > + min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
> > > #endif
> > >
> > > tboot_probe();
> >
> > http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
> >
>
> Thanks and sorry. Yes, it has been already fixed. I've rechecked only
> mainline.
>
> However, I think that there should be
> min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY), not just KERNEL_PGD_BOUNDARY
> (usually 768 for normal 1G/3G split), because swapper_pg_dir has only
> 1024 entries and 768+768 is 1536.
Yeah, this fix is preferable to the one that is currently sitting in
tip/x86/urgent. Curse you VMSPLIT!
next prev parent reply other threads:[~2015-11-07 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 13:18 [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Krzysztof Mazur
2015-11-06 13:27 ` Borislav Petkov
2015-11-06 14:11 ` Krzysztof Mazur
2015-11-06 15:00 ` Paolo Bonzini
2015-11-07 9:43 ` Matt Fleming [this message]
2015-11-07 9:44 ` [tip:x86/urgent] x86/setup: Fix " tip-bot for Krzysztof Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107094306.GA2387@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=krzysiek@podlesie.net \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).