From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbKGMmg (ORCPT ); Sat, 7 Nov 2015 07:42:36 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38456 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbbKGMme (ORCPT ); Sat, 7 Nov 2015 07:42:34 -0500 Date: Sat, 7 Nov 2015 12:42:30 +0000 From: Lee Jones To: Linus Torvalds Cc: Linux Kernel Mailing List Subject: Re: [GIT PULL] MFD for v4.4 Message-ID: <20151107124230.GF3378@x1> References: <20151106080421.GA3378@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Nov 2015, Linus Torvalds wrote: > On Fri, Nov 6, 2015 at 12:04 AM, Lee Jones wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-for-linus-4.4 > > Ugh. > > Maintainers, *please* check new warnings you introduce. We don't have > that many compiler warnings in the kernel, you shouldn't be > introducing new ones and not notice. > > This pull request introduces this silly new warning: > > drivers/mfd/rtsx_pcr.c: In function ‘rtsx_pci_set_pull_ctl’: > drivers/mfd/rtsx_pcr.c:565:6: warning: unused variable ‘err’ > [-Wunused-variable] > int err; > ^ > > due to commit b158b69a3765 ("mfd: rtsx: Simplify function return > logic") that removes the actual use of the variable, but not the > variable itself. I thought these were cleaned up. Apologies for that. Do you want me to submit a fix, or did you already rectify? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog