From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751900AbbKIR1Z (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Nov 2015 12:27:25 -0500
Received: from mail-pa0-f53.google.com ([209.85.220.53]:33446 "EHLO
	mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751353AbbKIR1W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Nov 2015 12:27:22 -0500
Date: Mon, 9 Nov 2015 09:27:18 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: parkbd - Drop bogus __init from
 parkbd_allocate_serio()
Message-ID: <20151109172718.GA9155@dtor-ws>
References: <1446911603-21242-1-git-send-email-geert@linux-m68k.org>
 <20151109130440.GC3868@sudip-pc>
 <CAMuHMdXjPFNH-r4e2TkDomXL+6j_B5Sn0W4JHQnbBppY3CenEw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdXjPFNH-r4e2TkDomXL+6j_B5Sn0W4JHQnbBppY3CenEw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 09, 2015 at 02:13:34PM +0100, Geert Uytterhoeven wrote:
> Hi Sudip,
> 
> On Mon, Nov 9, 2015 at 2:05 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Sat, Nov 07, 2015 at 04:53:23PM +0100, Geert Uytterhoeven wrote:
> >> WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the function parkbd_attach() to the function .init.text:parkbd_allocate_serio()
> >> The function parkbd_attach() references
> >> the function __init parkbd_allocate_serio().
> >> This is often because parkbd_attach lacks a __init
> >> annotation or the annotation of parkbd_allocate_serio is wrong.
> >>
> >> Commit 33ca8ab97cbb676d ("Input: parkbd - use parallel port device
> >> model") dropped the __init attribute from the sole caller of
> >> parkbd_allocate_serio(), but forgot to remove it from
> >> parkbd_allocate_serio() itself.
> >>
> >> Fixes: 33ca8ab97cbb676d ("Input: parkbd - use parallel port device model")
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > I don't see this with allmodconfig on i386 or on x86_64. How did you get
> > this warning? But anyway, looking at the code, i did miss attribute.
> 
> It depends on your compiler version. If your compiler decides to inline
> parkbd_allocate_serio(), you won't see that warning.
> 
> > Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Applied, thank you.

-- 
Dmitry