Re: [PATCH] tpm: fix compat 'ppi' link handling in tpm_chip_register()

Jarkko Sakkinen
2015-11-10T04:03:00Z

On Mon, Nov 09, 2015 at 03:47:20PM -0700, Jason Gunthorpe wrote:
> On Sun, Nov 08, 2015 at 09:51:07AM +0200, Jarkko Sakkinen wrote:
> > + if (rc && rc != -ENOENT) {
> > + tpm_chip_unregister(chip);
> > + return rc;
> > + }
> > + }
>
> This is still goofy looking, the list_add_tail_rcu should be the last
> thing done and cannot fail. Just code this with the usual goto based
> unwind and goto to do tpm_dev_del_device for the above failure.

Agreed that this would be cleaner.

> > +
> > return 0;
> > out_err:
> > tpm1_chip_unregister(chip);
>
> Which avoids calling tpm1_chip_unregister and tpm_chip_unregister in
> the same function, which looks so wrong to a casual read..

I'm not going to change the current patch at this point of release
cycle but this clean up definitely makes sense later on.

> Jason

/Jarkko