From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753610AbbKJQaW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Nov 2015 11:30:22 -0500
Received: from mga11.intel.com ([192.55.52.93]:48323 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752840AbbKJQaR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Nov 2015 11:30:17 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,271,1444719600"; 
   d="scan'208";a="816403652"
Date: Tue, 10 Nov 2015 08:28:59 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Len Brown <len.brown@intel.com>, Andi Kleen <andi.kleen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>, Paul Turner <pjt@google.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Punit Agrawal <punit.agrawal@arm.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [RFC PATCH v2 3/3] sched: introduce synchronized idle injection
Message-ID: <20151110082859.1493f106@icelake>
In-Reply-To: <20151110145823.GD17308@twins.programming.kicks-ass.net>
References: <1447114883-23851-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1447114883-23851-4-git-send-email-jacob.jun.pan@linux.intel.com>
	<20151110132324.GC17308@twins.programming.kicks-ass.net>
	<20151110060116.26cd5ff8@yairi>
	<20151110145823.GD17308@twins.programming.kicks-ass.net>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 10 Nov 2015 15:58:23 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Nov 10, 2015 at 06:01:16AM -0800, Jacob Pan wrote:
> > On Tue, 10 Nov 2015 14:23:24 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > > It looks like what you want is:
> > > 
> > > 	hrtimer_forward(hrt, period);
> > > 
> > > unconditionally.
> 
> > In the ideal world yes. But my thinking was that timers may not be
> > so accurate to deliver interrupts, over the time the timeout error
> > may accumulate so that eventually timers will be out of sync.
> 
> Timers have a global time base. Even if individual deliveries have an
> error, there is no accumulated error.
> 
great! I can get rid of the ktime_roundup(). It seems to work with
	now = hrtimer_cb_get_time(hrt);
	if (status)
		hrtimer_forward(hrt, now, ms_to_ktime(inject_interval));
	else
		hrtimer_forward(hrt, now, ms_to_ktime(duration));

The downside is that we need to restart the timers every time if
user were to change injection parameters, i.e. duration and percent.
Or do locking which might be too expensive. In the previous approach, it
will naturally catch up the parameter change.