From: Mark Brown <broonie@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: regulator: build warning in regulator_lock_supply()
Date: Tue, 10 Nov 2015 08:36:44 +0000 [thread overview]
Message-ID: <20151110083644.GA12392@sirena.org.uk> (raw)
In-Reply-To: <564162CC.5080609@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Mon, Nov 09, 2015 at 07:21:48PM -0800, Frank Rowand wrote:
> In the current Linus tree, new build warning.
> When CONFIG_DEBUG_LOCK_ALLOC is not enabled,
> drivers/regulator/core.c: In function 'regulator_lock_supply':
> drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]
> Introduced by commit
> 9f01cd4a915e1 ("regulator: core: introduce function to lock regulators and its supplies")
There was dome discussion about fixing the lockdep code so this doesn't
happen (since it's perfectly natural code). I didn't follow where that
went, there was a distraction about the user being buggy which was
addressed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-11-10 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 3:21 regulator: build warning in regulator_lock_supply() Frank Rowand
2015-11-10 7:36 ` Sascha Hauer
2015-11-10 8:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110083644.GA12392@sirena.org.uk \
--to=broonie@kernel.org \
--cc=frowand.list@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox