From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbbKJLQG (ORCPT ); Tue, 10 Nov 2015 06:16:06 -0500 Received: from mga03.intel.com ([134.134.136.65]:65470 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbbKJLQF (ORCPT ); Tue, 10 Nov 2015 06:16:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,270,1444719600"; d="scan'208";a="846883478" Date: Tue, 10 Nov 2015 13:13:14 +0200 From: Mika Westerberg To: Grygorii Strashko Cc: Thomas Gleixner , nsekhar@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tony Lindgren Subject: Re: [4.4-rc][PATCH] genirq / PM: restore system wake up from chained interrupts Message-ID: <20151110111314.GC1509@lahna.fi.intel.com> References: <1447149492-20699-1-git-send-email-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447149492-20699-1-git-send-email-grygorii.strashko@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2015 at 11:58:12AM +0200, Grygorii Strashko wrote: > Commit e509bd7da149 ("genirq: Allow migration of chained interrupts > by installing default action") breaks PCS wake up IRQ behaviour on > TI OMAP based platforms (dra7-evm). > > TI OMAP IRQ wake up configuration: > GIC-irqchip->PCM_IRQ > |- omap_prcm_register_chain_handler > |- PRCM-irqchip -> PRCM_IO_IRQ > |- pcs_irq_chain_handler > |- pinctrl-irqchip -> PCS_uart1_wakeup_irq > > This happens because IRQ PM code (irq/pm.c) is expected to ignore > chained interrupts by default: > static bool suspend_device_irq(struct irq_desc *desc) > { > if (!desc->action || desc->no_suspend_depth) > return false; > - it's expected !desc->action = true for chained interrupts; Indeed it is. I missed that, sorry. > but, after above change, all chained interrupt descriptors will > have default action handler installed - chained_action. > As result, chained interrupts will be silently disabled during system > suspend. > > Hence, fix it by introducing helper function irq_desc_is_chained() and > use it in suspend_device_irq() for chained interrupts identification > and skip them, once detected. > > Cc: Mika Westerberg FWIW, Reviewed-by: Mika Westerberg