From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbKJRQ1 (ORCPT ); Tue, 10 Nov 2015 12:16:27 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34475 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368AbbKJRQ0 (ORCPT ); Tue, 10 Nov 2015 12:16:26 -0500 Date: Tue, 10 Nov 2015 18:16:23 +0100 From: Thierry Reding To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] swiotlb: Make linux/swiotlb.h standalone includible Message-ID: <20151110171623.GA11139@ulmo> References: <1435753078-13391-1-git-send-email-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: <1435753078-13391-1-git-send-email-thierry.reding@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 02:17:58PM +0200, Thierry Reding wrote: > From: Thierry Reding >=20 > This header file uses the enum dma_data_direction and struct page types > without explicitly including the corresponding header files. This makes > it rely on the includer to have included the proper headers before. >=20 > To fix this, include linux/dma-direction.h and forward-declare struct > page. The swiotlb_free() function is also annotated __init, therefore > requires linux/init.h to be included as well. >=20 > Signed-off-by: Thierry Reding > --- > Hi Konrad, >=20 > I sent this about a year ago and at the time you said you had queued it > up, but it never disappeared from my local stack of patches, so here it > is again. >=20 > Thierry >=20 > include/linux/swiotlb.h | 3 +++ > 1 file changed, 3 insertions(+) Ping? >=20 > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index e7a018eaf3a2..017fced60242 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -1,10 +1,13 @@ > #ifndef __LINUX_SWIOTLB_H > #define __LINUX_SWIOTLB_H > =20 > +#include > +#include > #include > =20 > struct device; > struct dma_attrs; > +struct page; > struct scatterlist; > =20 > extern int swiotlb_force; > --=20 > 2.4.1 >=20 --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWQiZlAAoJEN0jrNd/PrOh+lIQAIGEidfakpxP5yonwTTvcGQY Q/S3CRhK6etHQpbYzCc7YuGFS9yLWp+4xm6jq83cQK/qtVR5Yvn9cEEBVgwqyuCf Oz2VYDwlbEi8Vc0oKHfx9iHJFnEYnFnSXsXby0dpeoFd1ZQHiVQWs1qabU+Q3Tvz ijVmdtQ38LOnSzbOkAt7/ZPpMXl/Q2Ld0tJxot9smdYVJiQu8X1a/f4u0Txx6pKG 4hMdm35XFmtexMPrQyEnJGe4KnDSB5MTgpKgdbzcRan08F9SiCqNwUlqpydVfXqu JNFpZR2XR/4iy6yHmD4iNw/Bp738TusN18FSjxXVhiIBnujWYMT129gjgfdwZk70 iuMzKP1dkI1WGugm8K1z/vNyEkZ1yzTvVIARsd/buUa6B2dpTxpoo3IP+4qrl0Sw k7i1LnNzYebOMQ8OXYMwKLa5BDsL8hPKUEHitJvHZqmD7xfy16FbR/QNE7kVzjky y7E0uageeexJv+UsF9SD5kcHqb/cPKMAjO37hJc5qZyr/kmlnbUBhg0Q7eqsRwNT eRaRCHRk1aYbehVGzbWK554C+ZKLqXViihjCGx5HjtYuT7gT2qOXshpu0/2lgobI G65s5Via5rSU8wxfHVIvGc/0XLVibeYDMb5KTQ4sZc98ghcXCuljN2Wdg6KoOIm/ ZhokCaAkpuV7BlNMwW+O =a/4e -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF--