Re: [PATCH 2/2] ptrace: task_stopped_code(ptrace => true) can't see TASK_STOPPED task

Tejun Heo
2015-11-23T23:15:42Z

On Thu, Nov 19, 2015 at 07:47:52PM +0100, Oleg Nesterov wrote:
> task_stopped_code()->task_is_stopped_or_traced() doesn't look right,
> the traced task must never be TASK_STOPPED.
>
> We can not add WARN_ON(task_is_stopped(p)), but this is only because
> do_wait() can race with PTRACE_ATTACH from another thread.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

I think it's a left over from before. We used to leave STOPPED tasks
alone during ptrace attach.

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun