From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbbKKNXK (ORCPT ); Wed, 11 Nov 2015 08:23:10 -0500 Received: from casper.infradead.org ([85.118.1.10]:44551 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbbKKNXI (ORCPT ); Wed, 11 Nov 2015 08:23:08 -0500 Date: Wed, 11 Nov 2015 14:23:04 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Steven Rostedt , Oleg Nesterov , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse Message-ID: <20151111132304.GQ17308@twins.programming.kicks-ass.net> References: <20151111122310.GO17308@twins.programming.kicks-ass.net> <20151111124940.GV3972@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151111124940.GV3972@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2015 at 04:49:40AM -0800, Paul E. McKenney wrote: > On Wed, Nov 11, 2015 at 01:23:10PM +0100, Peter Zijlstra wrote: > > Hi > > > > I recently ran into TASKS_RCU() and wondered why we can't use normal > > coding patterns to do the same. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Well, I cannot get too excited either way, but the diffstat for this > change is not particularly favorable. It also doesn't build with TASKS_RCU enabled it turns out. But the point is, nowhere else do we use this pattern. We always provide functions.