From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse
Date: Wed, 11 Nov 2015 05:27:34 -0800 [thread overview]
Message-ID: <20151111132734.GW3972@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151111132304.GQ17308@twins.programming.kicks-ass.net>
On Wed, Nov 11, 2015 at 02:23:04PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 04:49:40AM -0800, Paul E. McKenney wrote:
> > On Wed, Nov 11, 2015 at 01:23:10PM +0100, Peter Zijlstra wrote:
> > > Hi
> > >
> > > I recently ran into TASKS_RCU() and wondered why we can't use normal
> > > coding patterns to do the same.
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Well, I cannot get too excited either way, but the diffstat for this
> > change is not particularly favorable.
>
> It also doesn't build with TASKS_RCU enabled it turns out. But the point
> is, nowhere else do we use this pattern. We always provide functions.
RCU_TRACE() another very similar macro, and has been in place for quite
some time. Still within RCU, admittedly, but it does exist.
Thanx, Paul
prev parent reply other threads:[~2015-11-11 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 12:23 [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse Peter Zijlstra
2015-11-11 12:49 ` Paul E. McKenney
2015-11-11 13:23 ` Peter Zijlstra
2015-11-11 13:27 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111132734.GW3972@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox