From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbbKKN1b (ORCPT ); Wed, 11 Nov 2015 08:27:31 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:42019 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbbKKN1a (ORCPT ); Wed, 11 Nov 2015 08:27:30 -0500 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 11 Nov 2015 05:27:34 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Steven Rostedt , Oleg Nesterov , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse Message-ID: <20151111132734.GW3972@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20151111122310.GO17308@twins.programming.kicks-ass.net> <20151111124940.GV3972@linux.vnet.ibm.com> <20151111132304.GQ17308@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151111132304.GQ17308@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15111113-0009-0000-0000-00000FA96CD0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2015 at 02:23:04PM +0100, Peter Zijlstra wrote: > On Wed, Nov 11, 2015 at 04:49:40AM -0800, Paul E. McKenney wrote: > > On Wed, Nov 11, 2015 at 01:23:10PM +0100, Peter Zijlstra wrote: > > > Hi > > > > > > I recently ran into TASKS_RCU() and wondered why we can't use normal > > > coding patterns to do the same. > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > Well, I cannot get too excited either way, but the diffstat for this > > change is not particularly favorable. > > It also doesn't build with TASKS_RCU enabled it turns out. But the point > is, nowhere else do we use this pattern. We always provide functions. RCU_TRACE() another very similar macro, and has been in place for quite some time. Still within RCU, admittedly, but it does exist. Thanx, Paul