From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>,
clabbe.montjoie@gmail.com, davem@davemloft.net, wens@csie.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
stable@vger.kernel.org
Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize
Date: Wed, 11 Nov 2015 14:22:10 -0800 [thread overview]
Message-ID: <20151111222210.GI6114@lukather> (raw)
In-Reply-To: <20151109035848.GA2163@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Mon, Nov 09, 2015 at 11:58:48AM +0800, Herbert Xu wrote:
> Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de> wrote:
> >
> > Fixes: should rather point to the commit that caused the breakage in my
> > opinion. Which did this by intention:
>
> Absolutely not. That patch is correct and if you revert that
> you will simply end up registering a broken driver into the system
> that may then lead to crashes that can be triggered from user-space.
Yeah my point was that the commit log should be something like
"""
sun4i-ss implementaton of md5/sha1 is via ahash algorithms.
Commit 8996eafdcbad ('crypto: ahash - ensure statesize is non-zero')
made impossible to load them without giving statesize. This patch
specifiy statesize for sha1 and md5.
Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
"""
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-11 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 7:48 [PATCH] crypto: sun4i-ss: add missing statesize LABBE Corentin
2015-11-05 10:34 ` Chen-Yu Tsai
2015-11-05 16:07 ` Maxime Ripard
2015-11-06 4:56 ` Herbert Xu
2015-11-08 17:50 ` Maxime Ripard
2015-11-08 18:22 ` Christoph Biedl
2015-11-09 3:58 ` Herbert Xu
2015-11-11 22:22 ` Maxime Ripard [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-13 13:10 LABBE Corentin
2015-11-17 14:09 ` Herbert Xu
2015-11-17 14:26 ` LABBE Corentin
2015-11-17 14:27 ` Herbert Xu
2015-11-17 21:51 ` Greg KH
[not found] <1447054026-4243-1-git-send-email-clabbe.montjoie@gmail.com>
2015-11-09 7:38 ` Herbert Xu
2015-10-20 18:05 LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111222210.GI6114@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel.bfrz@manchmal.in-ulm.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=stable@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox