* Re: MIPS: BMIPS: Enable GZIP ramdisk and timed printks
@ 2015-11-12 10:18 Andreas Ziegler
2015-11-12 10:36 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Ziegler @ 2015-11-12 10:18 UTC (permalink / raw)
To: Florian Fainelli
Cc: Kevin Cernekee, Dragan Stancevic, Ralf Baechle, blogic,
Jonas Gorski, linux-mips, linux-kernel@vger.kernel.org,
Valentin Rothberg, Paul Bolle
Hi Florian,
your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks"
showed up as commit fb9e5642aa9e in linux-next today (that is,
next-20151112). I noticed it because we (a research group from
Erlangen[0]) are running daily checks on linux-next.
Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig,
but one of them has a typo (line 37):
CONFIG_PRINK_TIME=y
which should instead say (notice the missing 'T'):
CONFIG_PRINTK_TIME=y
Not sure how this got two Reviewed-by's, as this simple mistake could
have been easily spotted by running scripts/checkkconfigsymbols.py on
the patch.
Regards,
Andreas
[0] https://cados.cs.fau.de
Original patchwork: https://patchwork.linux-mips.org/patch/11307/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: MIPS: BMIPS: Enable GZIP ramdisk and timed printks
2015-11-12 10:18 MIPS: BMIPS: Enable GZIP ramdisk and timed printks Andreas Ziegler
@ 2015-11-12 10:36 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2015-11-12 10:36 UTC (permalink / raw)
To: Andreas Ziegler
Cc: Florian Fainelli, Kevin Cernekee, Dragan Stancevic, blogic,
Jonas Gorski, linux-mips, linux-kernel@vger.kernel.org,
Valentin Rothberg, Paul Bolle
On Thu, Nov 12, 2015 at 11:18:30AM +0100, Andreas Ziegler wrote:
> Hi Florian,
>
> your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks"
> showed up as commit fb9e5642aa9e in linux-next today (that is,
> next-20151112). I noticed it because we (a research group from
> Erlangen[0]) are running daily checks on linux-next.
>
> Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig,
> but one of them has a typo (line 37):
>
> CONFIG_PRINK_TIME=y
>
> which should instead say (notice the missing 'T'):
>
> CONFIG_PRINTK_TIME=y
>
> Not sure how this got two Reviewed-by's, as this simple mistake could
> have been easily spotted by running scripts/checkkconfigsymbols.py on
> the patch.
Sigh, fixed.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-12 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-12 10:18 MIPS: BMIPS: Enable GZIP ramdisk and timed printks Andreas Ziegler
2015-11-12 10:36 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox