From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Jörg Rödel" <joro@8bytes.org>, "kvm ML" <kvm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: Shut up unhandled MSR warnings
Date: Thu, 12 Nov 2015 13:16:13 +0100 [thread overview]
Message-ID: <20151112121613.GC3838@pd.tnic> (raw)
In-Reply-To: <20151112105958.GA3838@pd.tnic>
On Thu, Nov 12, 2015 at 11:59:58AM +0100, Borislav Petkov wrote:
> On Thu, Nov 12, 2015 at 11:33:33AM +0100, Paolo Bonzini wrote:
> > Yes, see guest_cpuid_has_* for an example of reading the CPUID values.
> >
> > But if it's defined for _all_ models starting at family 21, we can just
> > do it unconditionally.
>
> The thing is, those bits are Reserved again on the next family 22. Lemme
> take a look at guest_cpuid_has_* and see how ugly it gets.
Ok, I see there's guest_cpuid_is_amd() but I'd need also family and model.
How about adding also
guest_cpuid_family(), guest_cpuid_model(), guest_cpuid_stepping()? Those
could be quite useful in other contexts maybe.
Or, I can do a single function which simply returns CPUID_1_EAX of the
guest vcpu and caller can then pick stuff apart...
Thoughts?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-11-12 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 10:13 Shut up unhandled MSR warnings Borislav Petkov
2015-11-12 10:33 ` Paolo Bonzini
2015-11-12 10:59 ` Borislav Petkov
2015-11-12 12:16 ` Borislav Petkov [this message]
2015-11-12 12:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112121613.GC3838@pd.tnic \
--to=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox