From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: Dmitry Krivenok <krivenok.dmitry@gmail.com>
Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net,
Len Brown <lenb@kernel.org>,
dan.j.williams@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org
Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru
Date: Thu, 12 Nov 2015 08:33:42 -0700 [thread overview]
Message-ID: <20151112153342.GA129240@tevye.fc.hp.com> (raw)
In-Reply-To: <CAJN_NGZufvD=GLkw2sscCOEdY9JB0ADSQzggrnEeeEGtdZkiOQ@mail.gmail.com>
On Thu, Nov 12, 2015 at 12:52:47AM +0300, Dmitry Krivenok wrote:
> > but, we still want to go through entire list.
>
> Shouldn't you break the loop immediately after you found the bus and sent ioctl?
> Maybe I'm missing something, but I see no reason to continue iterating
> after the bus was found (even though you don't do anything and just
> compare IDs and "continue").
okay, i understand now what you're saying. i'll address in version 2.
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard Enterprise
-----------------------------------------------------------------------------
next prev parent reply other threads:[~2015-11-12 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 14:02 [PATCH 3/4] nvdimm: Add IOCTL pass thru Dmitry Krivenok
2015-11-09 21:59 ` Jerry Hoemann
2015-11-10 15:05 ` Dmitry Krivenok
2015-11-11 21:44 ` Jerry Hoemann
2015-11-11 21:52 ` Dmitry Krivenok
2015-11-12 15:33 ` Jerry Hoemann [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-06 22:27 [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
2015-11-06 22:27 ` [PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann
2015-11-10 16:24 ` Jeff Moyer
2015-11-10 21:36 ` Jerry Hoemann
2015-11-10 21:45 ` Jeff Moyer
2015-11-10 22:15 ` Jerry Hoemann
2015-11-10 21:54 ` Jeff Moyer
2015-11-11 1:42 ` Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112153342.GA129240@tevye.fc.hp.com \
--to=jerry.hoemann@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=krivenok.dmitry@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=rjw@rjwysocki.net \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox