From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
paulmck@linux.vnet.ibm.com, corbet@lwn.net, mhocko@kernel.org,
dhowells@redhat.com, torvalds@linux-foundation.org,
will.deacon@arm.com, Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 4/4] locking: Introduce smp_cond_acquire()
Date: Thu, 12 Nov 2015 20:33:02 +0100 [thread overview]
Message-ID: <20151112193302.GA9988@redhat.com> (raw)
In-Reply-To: <20151112180203.GF17308@twins.programming.kicks-ass.net>
On 11/12, Peter Zijlstra wrote:
>
> On Thu, Nov 12, 2015 at 07:38:07PM +0100, Oleg Nesterov wrote:
> > It seems that PPC needs to define smp_mb__before_spinlock() as full mb(),
> > no?
>
> It does:
>
> arch/powerpc/include/asm/barrier.h:#define smp_mb__before_spinlock() smp_mb()
Ah, indeed, thanks.
And given that it also defines smp_mb__after_unlock_lock() as smp_mb(),
I am starting to understand how it can help to avoid the races with
spin_unlock_wait() in (for example) do_exit().
But as Boqun has already mentioned, this means that mb__after_unlock_lock()
has the new meaning which should be documented.
Hmm. And 12d560f4 "Privatize smp_mb__after_unlock_lock()" should be reverted
then ;)
Oleg.
next prev parent reply other threads:[~2015-11-12 18:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 13:29 [PATCH 0/4] scheduler ordering bits Peter Zijlstra
2015-11-02 13:29 ` [PATCH 1/4] sched: Better document the try_to_wake_up() barriers Peter Zijlstra
2015-12-04 0:09 ` Byungchul Park
2015-12-04 0:58 ` Byungchul Park
2015-11-02 13:29 ` [PATCH 2/4] sched: Document Program-Order guarantees Peter Zijlstra
2015-11-02 20:27 ` Paul Turner
2015-11-02 20:34 ` Peter Zijlstra
2015-11-02 22:09 ` Paul Turner
2015-11-02 22:12 ` Peter Zijlstra
2015-11-20 10:02 ` Peter Zijlstra
2015-11-20 14:08 ` Boqun Feng
2015-11-20 14:18 ` Peter Zijlstra
2015-11-20 14:21 ` Boqun Feng
2015-11-20 19:41 ` Peter Zijlstra
2015-11-02 13:29 ` [PATCH 3/4] sched: Fix a race in try_to_wake_up() vs schedule() Peter Zijlstra
2015-11-02 13:29 ` [PATCH 4/4] locking: Introduce smp_cond_acquire() Peter Zijlstra
2015-11-02 13:57 ` Peter Zijlstra
2015-11-02 17:43 ` Will Deacon
2015-11-03 1:14 ` Paul E. McKenney
2015-11-03 1:25 ` Linus Torvalds
2015-11-02 17:42 ` Will Deacon
2015-11-02 18:08 ` Linus Torvalds
2015-11-02 18:37 ` Will Deacon
2015-11-02 19:17 ` Linus Torvalds
2015-11-02 19:57 ` Will Deacon
2015-11-02 20:23 ` Peter Zijlstra
2015-11-02 21:56 ` Peter Zijlstra
2015-11-03 1:57 ` Paul E. McKenney
2015-11-03 19:40 ` Linus Torvalds
2015-11-04 3:57 ` Paul E. McKenney
2015-11-04 4:43 ` Linus Torvalds
2015-11-04 12:54 ` Paul E. McKenney
2015-11-02 20:36 ` David Howells
2015-11-02 20:40 ` Peter Zijlstra
2015-11-02 21:11 ` Linus Torvalds
2015-11-03 17:59 ` Oleg Nesterov
2015-11-03 18:23 ` Peter Zijlstra
2015-11-11 9:39 ` Boqun Feng
2015-11-11 10:34 ` Boqun Feng
2015-11-11 19:53 ` Oleg Nesterov
2015-11-12 13:50 ` Paul E. McKenney
2015-11-11 12:12 ` Peter Zijlstra
2015-11-11 19:39 ` Oleg Nesterov
2015-11-11 21:23 ` Linus Torvalds
2015-11-12 7:14 ` Boqun Feng
2015-11-12 10:28 ` Peter Zijlstra
2015-11-12 15:00 ` Oleg Nesterov
2015-11-12 14:40 ` Paul E. McKenney
2015-11-12 14:49 ` Boqun Feng
2015-11-12 15:02 ` Paul E. McKenney
2015-11-12 21:53 ` Will Deacon
2015-11-12 14:50 ` Peter Zijlstra
2015-11-12 15:01 ` Paul E. McKenney
2015-11-12 15:08 ` Peter Zijlstra
2015-11-12 15:20 ` Paul E. McKenney
2015-11-12 21:25 ` Will Deacon
2015-11-12 15:18 ` Boqun Feng
2015-11-12 18:38 ` Oleg Nesterov
2015-11-12 18:02 ` Peter Zijlstra
2015-11-12 19:33 ` Oleg Nesterov [this message]
2015-11-12 18:59 ` Paul E. McKenney
2015-11-12 21:33 ` Will Deacon
2015-11-12 23:43 ` Paul E. McKenney
2015-11-16 13:58 ` Will Deacon
2015-11-12 18:21 ` Linus Torvalds
2015-11-12 22:09 ` Will Deacon
2015-11-16 15:56 ` Peter Zijlstra
2015-11-16 16:04 ` Peter Zijlstra
2015-11-16 16:24 ` Will Deacon
2015-11-16 16:44 ` Paul E. McKenney
2015-11-16 16:46 ` Will Deacon
2015-11-16 17:15 ` Paul E. McKenney
2015-11-16 21:58 ` Linus Torvalds
2015-11-17 11:51 ` Will Deacon
2015-11-17 21:01 ` Paul E. McKenney
2015-11-18 11:25 ` Will Deacon
2015-11-19 18:01 ` Will Deacon
2015-11-20 10:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112193302.GA9988@redhat.com \
--to=oleg@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox