From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753693AbbKMI75 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Nov 2015 03:59:57 -0500
Received: from mail-wm0-f51.google.com ([74.125.82.51]:34666 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750760AbbKMI7z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Nov 2015 03:59:55 -0500
Date: Fri, 13 Nov 2015 09:59:43 +0100
From: Dave Penkler <dpenkler@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, peter.chen@freescale.com,
        teuniz@gmail.com, USB <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] Add ioctls to enable and disable local controls
 on an instrument
Message-ID: <20151113085943.GA1567@slacky>
References: <20151111110827.GA1785@slacky>
 <20151111112108.GE1875@slacky>
 <CAHp75Vft4aC_Xf3rP9_Zh9nv80hxdQEipp_uziWU2kchqLgz8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vft4aC_Xf3rP9_Zh9nv80hxdQEipp_uziWU2kchqLgz8A@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,
On Wed, Nov 11, 2015 at 09:36:41PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 11, 2015 at 1:21 PM, Dave Penkler <dpenkler@gmail.com> wrote:
> > These ioctls provide support for the USBTMC-USB488 control requests
> > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT

snip

> > +                       goto exit;
> > +               }
> > +               wValue = (val) ? 1 : 0;
> 
> !!val;
I checked by compiling both variants - the compiler emits identical code
for both so I prefer to keep the original as it is more obvious for
maintainers reading the code.

regards,
-Dave