Re: [PATCH 3/4] sched: introduce synchronized idle injection

Morten Rasmussen
2015-11-18T15:09:03Z

On Wed, Nov 18, 2015 at 06:52:33AM -0800, Jacob Pan wrote:
> On Wed, 18 Nov 2015 14:04:41 +0000
> Morten Rasmussen <morten.rasmussen@arm.com> wrote:
>
> > Then I'm confused :-/
> >
> > I see the hrtimers, but the actual idle duration appears to be in
> > ticks rather than ms and then converted later.
> >
> > +/* Duration of idle time in ticks of each injection period
> > */ +unsigned int sysctl_sched_cfs_idle_inject_duration = 5UL;
> >
> > ...and futher down we have:
> >
> > + duration_msec =
> > jiffies_to_msecs(sysctl_sched_cfs_idle_inject_duration);
> I used hrtimers but still round around tick boundaries of ktime.
> It is more reliable than jiffies in terms of getting timely updates.

Okay. But it does mean that the defeault idle period is 5 ticks (50ms @
HZ=100) and not 5 ms.