Re: [PATCH v3 1/2] cputime: fix invalid gtime in proc

Peter Zijlstra
2015-11-02T16:13:58Z

On Fri, Oct 30, 2015 at 12:46:39AM +0000, Hiroshi Shimamoto wrote:
> +++ b/kernel/sched/cputime.c
> @@ -786,6 +786,9 @@ cputime_t task_gtime(struct task_struct *t)
> unsigned int seq;
> cputime_t gtime;
>
> + if (!context_tracking_is_enabled())
> + return t->gtime;
> +

Yeah, not happy about that.. why do we have to touch context tracking
muck to find vtime state etc.

> do {
> seq = read_seqbegin(&t->vtime_seqlock);
>
> --
> 1.8.3.1
>