From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbbKMWGj (ORCPT ); Fri, 13 Nov 2015 17:06:39 -0500 Received: from mail.kernel.org ([198.145.29.136]:46129 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094AbbKMWGg (ORCPT ); Fri, 13 Nov 2015 17:06:36 -0500 Date: Fri, 13 Nov 2015 23:06:29 +0100 From: Sebastian Reichel To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] HSI: Remove struct hsi_client private fields from kernel-doc Message-ID: <20151113220628.GA24590@earth> References: <1444288308-11469-1-git-send-email-javier@osg.samsung.com> <56461906.2000107@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <56461906.2000107@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 13, 2015 at 02:08:22PM -0300, Javier Martinez Canillas wrote: > Hello Sebastian, >=20 > On 10/08/2015 04:11 AM, Javier Martinez Canillas wrote: > > The kernel-doc how to says that structure fields that are inside a > > "private:" area shouldn't be listed in the generated documentation > > but the private fields for struct hsi_client private are listed. > >=20 > > This also fixes the following make htmldocs warnings: > >=20 > > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typed= ef member 'e_handler' description in 'hsi_client' > > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typed= ef member 'pclaimed' description in 'hsi_client' > > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typed= ef member 'nb' description in 'hsi_client' > >=20 > > Signed-off-by: Javier Martinez Canillas > >=20 > > --- > >=20 > > include/linux/hsi/hsi.h | 3 --- > > 1 file changed, 3 deletions(-) > >=20 > > diff --git a/include/linux/hsi/hsi.h b/include/linux/hsi/hsi.h > > index 5dd60c2e120f..2790591c77cf 100644 > > --- a/include/linux/hsi/hsi.h > > +++ b/include/linux/hsi/hsi.h > > @@ -135,9 +135,6 @@ static inline int hsi_register_board_info(struct hs= i_board_info const *info, > > * @device: Driver model representation of the device > > * @tx_cfg: HSI TX configuration > > * @rx_cfg: HSI RX configuration > > - * @e_handler: Callback for handling port events (RX Wake High/Low) > > - * @pclaimed: Keeps tracks if the clients claimed its associated HSI p= ort > > - * @nb: Notifier block for port events > > */ > > struct hsi_client { > > struct device device; > >=20 >=20 > Any comments about this patch? The patch looks fine. I will queue it for 4.5 once 4.4-rc1 has been released. -- Sebastian --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWRl7hAAoJENju1/PIO/qaiNEP/14PcCuaZvVrEHzL+lR/8A+Q g9TW/wm+bN8mvtIcQwLto7vjSTWbHTWgEbxeMxN8Wgz4GB0EapTVGO5SEzfmz77o LKB88EZrWA205Go2olZByf3UQJb61GOE1LeDNaMrOYVIWGFRtr/C5lp2/m4c6anW 2mEFXGaqbwED7SsPBWfuEAiT0xBH/yFoqC2Gq+fVVI9uVJdaW/Y6uflarMwxKclf dlUYGRwoxawC/k4OSK7NxqzT918ERVtHoFHF50EmRtFXFdh4Ix/8cnOeiNpFKwGI GOa/3jybq1fRpoQ5wl41uZCRbWtDfQ8oIqncD6AzmyCmhc6KuD4VvqH+UD3MsL4o YyJi3nHlYqOyPxQDbx1AEuVf5AE5PP2dFtTDN2a8/uAMXj0eSsSJmxEo9vI/m5i8 GcSAcp0hOh21hvCjaTdM+r7zHRgtdSNOizn4XywefGH0FEX1hmia/E4pf9R1HG9A Ce2kNJ6WXCeUyjb/TY/HSznAvj4shhKKniVRn0bi6TnStfH0nyJmkKLVANx4bdZQ joomHOk6BoCnRR1JrNWq6w8jEW1u0E/dQmn4LEWHX+JHJqRwtCfyUzi7ycD43N6+ /Xe/+VVbN1TIAg1vP03i56SCMweIn4AmF15p8j2A4GRqrMwJi420pHjNq8Q8Zdms 8u/uu7M5p/t3XKW4DJ/b =uXm+ -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--