* [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF
@ 2015-11-03 10:28 Peter Ujfalusi
2015-11-03 10:46 ` Arnd Bergmann
2015-11-16 3:33 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2015-11-03 10:28 UTC (permalink / raw)
To: vinod.koul; +Cc: linux-kernel, dmaengine, devicetree, robh+dt, grant.likely
of_dma_request_slave_channel should return either pointer for valid
dma_chan or ERR_PTR() error code, NULL is not expected to be returned.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
include/linux/of_dma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
index 36112cdd665a..b90d8ec57c1f 100644
--- a/include/linux/of_dma.h
+++ b/include/linux/of_dma.h
@@ -80,7 +80,7 @@ static inline int of_dma_router_register(struct device_node *np,
static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
const char *name)
{
- return NULL;
+ return ERR_PTR(-ENODEV);
}
static inline struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF
2015-11-03 10:28 [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF Peter Ujfalusi
@ 2015-11-03 10:46 ` Arnd Bergmann
2015-11-16 3:33 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-11-03 10:46 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: vinod.koul, linux-kernel, dmaengine, devicetree, robh+dt,
grant.likely
On Tuesday 03 November 2015 12:28:10 Peter Ujfalusi wrote:
> of_dma_request_slave_channel should return either pointer for valid
> dma_chan or ERR_PTR() error code, NULL is not expected to be returned.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF
2015-11-03 10:28 [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF Peter Ujfalusi
2015-11-03 10:46 ` Arnd Bergmann
@ 2015-11-16 3:33 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-11-16 3:33 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: linux-kernel, dmaengine, devicetree, robh+dt, grant.likely
On Tue, Nov 03, 2015 at 12:28:10PM +0200, Peter Ujfalusi wrote:
> of_dma_request_slave_channel should return either pointer for valid
> dma_chan or ERR_PTR() error code, NULL is not expected to be returned.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-16 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 10:28 [PATCH] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF Peter Ujfalusi
2015-11-03 10:46 ` Arnd Bergmann
2015-11-16 3:33 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox