From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbbKPDsW (ORCPT ); Sun, 15 Nov 2015 22:48:22 -0500 Received: from mga09.intel.com ([134.134.136.24]:7081 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbbKPDsV (ORCPT ); Sun, 15 Nov 2015 22:48:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,300,1444719600"; d="scan'208";a="851522485" Date: Mon, 16 Nov 2015 09:22:04 +0530 From: Vinod Koul To: Arnd Bergmann Cc: dmaengine@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: at_xdmac: use %pad format string for dma_addr_t Message-ID: <20151116035204.GA25173@localhost> References: <3796793.2XNherj1df@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3796793.2XNherj1df@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 03:16:53PM +0100, Arnd Bergmann wrote: > dma_addr_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as > gcc correctly warns: > > drivers/dma/at_xdmac.c: In function 'at_xdmac_interleaved_queue_desc': > drivers/dma/at_xdmac.c:922:51: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > > This changes the format strings to use the special "%pad" format > string that prints a dma_addr_t, and changes the arguments so we > pass the address by reference as required. Applied, thanks -- ~Vinod