From: Pavel Machek <pavel@ucw.cz>
To: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>
Cc: rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org,
len.brown@intel.com, gregkh@linuxfoundation.org,
broonie@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / Domains: export pm_genpd_add_device symbol
Date: Mon, 16 Nov 2015 10:54:11 +0100 [thread overview]
Message-ID: <20151116095411.GA8451@amd> (raw)
In-Reply-To: <1447664848-11372-1-git-send-email-Maruthi.Bayyavarapu@amd.com>
On Mon 2015-11-16 14:37:28, Maruthi Srinivas Bayyavarapu wrote:
> Drivers which can be built as loadable module needs
> symbol - pm_genpd_add_device to be exported. Those drivers
> create platform devices which comes under a powerdomain.
>
> Signed-off-by: Maruthi Bayyavarapu <maruthi.bayyavarapu@amd.com>
> ---
> drivers/base/power/domain.c | 7 +++++++
> include/linux/pm_domain.h | 9 ++-------
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index f932058..72998f8 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1253,6 +1253,13 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
> return ret;
> }
>
> +int pm_genpd_add_device(struct generic_pm_domain *genpd,
> + struct device *dev)
> +{
> + return __pm_genpd_add_device(genpd, dev, NULL);
> +}
> +EXPORT_SYMBOL_GPL(pm_genpd_add_device);
> +
Hmm. Alternatively, you can just export __pm_genpd_add_device and let
the static inline do its magic?
Pavel
> /**
> * pm_genpd_remove_device - Remove a device from an I/O PM domain.
> * @genpd: PM domain to remove the device from.
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index ba4ced3..f9e2f7e 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -114,7 +114,8 @@ extern struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev);
> extern int __pm_genpd_add_device(struct generic_pm_domain *genpd,
> struct device *dev,
> struct gpd_timing_data *td);
> -
> +extern int pm_genpd_add_device(struct generic_pm_domain *genpd,
> + struct device *dev);
> extern int pm_genpd_remove_device(struct generic_pm_domain *genpd,
> struct device *dev);
> extern int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
> @@ -163,12 +164,6 @@ static inline void pm_genpd_init(struct generic_pm_domain *genpd,
> }
> #endif
>
> -static inline int pm_genpd_add_device(struct generic_pm_domain *genpd,
> - struct device *dev)
> -{
> - return __pm_genpd_add_device(genpd, dev, NULL);
> -}
> -
> #ifdef CONFIG_PM_GENERIC_DOMAINS_SLEEP
> extern void pm_genpd_syscore_poweroff(struct device *dev);
> extern void pm_genpd_syscore_poweron(struct device *dev);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-11-16 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 9:07 [PATCH] PM / Domains: export pm_genpd_add_device symbol Maruthi Srinivas Bayyavarapu
2015-11-16 9:54 ` Pavel Machek [this message]
2015-11-16 11:08 ` Ulf Hansson
2015-11-16 17:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116095411.GA8451@amd \
--to=pavel@ucw.cz \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox