From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbbKPJyQ (ORCPT ); Mon, 16 Nov 2015 04:54:16 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50442 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbbKPJyN (ORCPT ); Mon, 16 Nov 2015 04:54:13 -0500 Date: Mon, 16 Nov 2015 10:54:11 +0100 From: Pavel Machek To: Maruthi Srinivas Bayyavarapu Cc: rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, len.brown@intel.com, gregkh@linuxfoundation.org, broonie@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / Domains: export pm_genpd_add_device symbol Message-ID: <20151116095411.GA8451@amd> References: <1447664848-11372-1-git-send-email-Maruthi.Bayyavarapu@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447664848-11372-1-git-send-email-Maruthi.Bayyavarapu@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2015-11-16 14:37:28, Maruthi Srinivas Bayyavarapu wrote: > Drivers which can be built as loadable module needs > symbol - pm_genpd_add_device to be exported. Those drivers > create platform devices which comes under a powerdomain. > > Signed-off-by: Maruthi Bayyavarapu > --- > drivers/base/power/domain.c | 7 +++++++ > include/linux/pm_domain.h | 9 ++------- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index f932058..72998f8 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1253,6 +1253,13 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, > return ret; > } > > +int pm_genpd_add_device(struct generic_pm_domain *genpd, > + struct device *dev) > +{ > + return __pm_genpd_add_device(genpd, dev, NULL); > +} > +EXPORT_SYMBOL_GPL(pm_genpd_add_device); > + Hmm. Alternatively, you can just export __pm_genpd_add_device and let the static inline do its magic? Pavel > /** > * pm_genpd_remove_device - Remove a device from an I/O PM domain. > * @genpd: PM domain to remove the device from. > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h > index ba4ced3..f9e2f7e 100644 > --- a/include/linux/pm_domain.h > +++ b/include/linux/pm_domain.h > @@ -114,7 +114,8 @@ extern struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev); > extern int __pm_genpd_add_device(struct generic_pm_domain *genpd, > struct device *dev, > struct gpd_timing_data *td); > - > +extern int pm_genpd_add_device(struct generic_pm_domain *genpd, > + struct device *dev); > extern int pm_genpd_remove_device(struct generic_pm_domain *genpd, > struct device *dev); > extern int pm_genpd_add_subdomain(struct generic_pm_domain *genpd, > @@ -163,12 +164,6 @@ static inline void pm_genpd_init(struct generic_pm_domain *genpd, > } > #endif > > -static inline int pm_genpd_add_device(struct generic_pm_domain *genpd, > - struct device *dev) > -{ > - return __pm_genpd_add_device(genpd, dev, NULL); > -} > - > #ifdef CONFIG_PM_GENERIC_DOMAINS_SLEEP > extern void pm_genpd_syscore_poweroff(struct device *dev); > extern void pm_genpd_syscore_poweron(struct device *dev); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html