From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbbKPLk1 (ORCPT ); Mon, 16 Nov 2015 06:40:27 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35243 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbKPLkX (ORCPT ); Mon, 16 Nov 2015 06:40:23 -0500 Date: Mon, 16 Nov 2015 12:40:43 +0100 From: Johan Hovold To: Konstantin Shkolnyy Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug Message-ID: <20151116114043.GA6627@localhost> References: <1446066174-17904-1-git-send-email-konstantin.shkolnyy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446066174-17904-1-git-send-email-konstantin.shkolnyy@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 04:02:54PM -0500, Konstantin Shkolnyy wrote: > cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped. > However, SET_LINE_CTL functions properly. When the driver tries to modify > the register, it reads it, modifies some bits and writes back. Because the > read bytes were swapped, this often results in an invalid value to be > written. In turn, this causes cp2108 respond with a stall. The stall > sometimes doesn't clear properly and cp2108 starts responding to following > valid commands also with stalls, effectively failing. > > Signed-off-by: Konstantin Shkolnyy All three now applied (with amended commit messages) for next. Thanks, Johan