From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbbKPMQa (ORCPT ); Mon, 16 Nov 2015 07:16:30 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41539 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbbKPMQ2 (ORCPT ); Mon, 16 Nov 2015 07:16:28 -0500 Date: Mon, 16 Nov 2015 13:16:25 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Marcus Folkesson Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: imx: fix clk_prepare/unprepare usage Message-ID: <20151116121625.GD22022@pengutronix.de> References: <1447322328-5171-1-git-send-email-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1447322328-5171-1-git-send-email-marcus.folkesson@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 10:58:48AM +0100, Marcus Folkesson wrote: > clk_prepare/unprapare APIs are not allowed in atomic context, so > move prepare/unprepare to probe/remove and use clk_enable/disable > instead. > > Signed-off-by: Marcus Folkesson Do you see a problem? I don't claim your patch is wrong, I just wonder why nobody else noticed it earlier (including me). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |